Clean up lint warnings left after the framework dependency bump #3

New issue

Open

opened 2026-06-14 23:52:05 +00:00 by forgejo-admin · 0 comments

forgejo-admin commented

2026-06-14 23:52:05 +00:00

Owner

Summary

The framework dep bump (commit ad57275: React 19, zod 4, TS 6, eslint 10, eslint-plugin-react-hooks 7, etc.) is error-free on lint, but left 10 warnings behind. They don't fail the build, but worth clearing.

Known warnings

@typescript-eslint/no-unused-vars — packages/shared/src/lib/lunarPhase.ts (LunarPhase, LunarMonth, date), packages/trpc-utils/src/lib/middleware.ts (error)
react-hooks/exhaustive-deps — apps/lunacycle-web/src/contexts/AuthContext.tsx, apps/nigredo-web/src/contexts/AuthContext.tsx (missing refreshAccessToken dep; effect intentionally runs once on mount — decide: wrap in useCallback + add dep, or document)
react-refresh/only-export-components — apps/lunacycle-web/src/pages/Admin.tsx (non-component export in a component file)

Notes

Run bun run lint for the live list. Some are trivial (drop unused imports); the exhaustive-deps ones in the AuthContexts need a small judgment call now that the helpers are hoisted (see ad57275).

Acceptance criteria

bun run lint reports 0 warnings, or each remaining warning has a deliberate inline suppression with justification.

## Summary The framework dep bump (commit `ad57275`: React 19, zod 4, TS 6, eslint 10, eslint-plugin-react-hooks 7, etc.) is **error-free** on lint, but left **10 warnings** behind. They don't fail the build, but worth clearing. ## Known warnings - `@typescript-eslint/no-unused-vars` — `packages/shared/src/lib/lunarPhase.ts` (`LunarPhase`, `LunarMonth`, `date`), `packages/trpc-utils/src/lib/middleware.ts` (`error`) - `react-hooks/exhaustive-deps` — `apps/lunacycle-web/src/contexts/AuthContext.tsx`, `apps/nigredo-web/src/contexts/AuthContext.tsx` (missing `refreshAccessToken` dep; effect intentionally runs once on mount — decide: wrap in `useCallback` + add dep, or document) - `react-refresh/only-export-components` — `apps/lunacycle-web/src/pages/Admin.tsx` (non-component export in a component file) ## Notes Run `bun run lint` for the live list. Some are trivial (drop unused imports); the `exhaustive-deps` ones in the AuthContexts need a small judgment call now that the helpers are hoisted (see `ad57275`). ## Acceptance criteria - [ ] `bun run lint` reports 0 warnings, **or** each remaining warning has a deliberate inline suppression with justification.

forgejo-admin added the

type/tech-debt

area/ci

priority/low

labels

2026-06-14 23:52:05 +00:00