feat(celilo)!: move to @celilo/capabilities 2.0.0, drop the on_uninstall hook #51
No reviewers
Labels
No labels
area/auth
area/backend
area/ci
area/deploy
area/e2e
area/frontend
area/shared
blocked
good-first-issue
needs-info
priority/high
priority/low
priority/medium
type/bug
type/chore
type/docs
type/feature
type/tech-debt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
celilo/lunacycle!51
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "caps2-lunacycle"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
celilo v1.0.0 ships
@celilo/capabilities2.0.0, which takes withdrawal off theconsumer-facing capability surface. Removing a module now dispatches
on_consumer_removedto every provider of every capability it declared, and eachprovider withdraws what it minted.
PublicWebCapability.unregister_routesis gone.This repo was pinned to
^0.5.0, several majors behind.What changed
celilo/scripts/package.json:@celilo/capabilities^0.5.0→^2.0.0, lockfile refreshed.teardown-web.tsandteardown-web.test.ts. The wholeon_uninstallhook existed only to callunregister_routes; caddy withdraws lunacycle's routes itself now.on_uninstallentry frommanifest.yml. A hook entry pointing at a deleted script fails the whole module load.unregister_routesspy fromsetup-web.test.ts.New gate
manifest-cd.test.tsasserted thaton_backupandon_restorepoint at realfiles. It now asserts that every declared hook does. Deleting a script and
forgetting its manifest entry is the easy half of this mistake to make, and the
consequence is a module that will not load at all.
Proved the check fails: re-added the
on_uninstallentry pointing at the deletedteardown-web.tsand the run went red onon_uninstall script exists on disk,then restored.
Not changed, deliberately
requires.capabilities.public_webstays at3.0.0. capabilities 2.0.0 declaresthe contract at
3.1.0— same major, and nothing lunacycle calls moved. Thedeployed caddy (2.3.0) satisfies it.
The other 2.0.0 breaking changes (
FirewallCapability,RegisterTrustedSourceRequest.subnets,IssueRunnerTokenRequest.runnerName,PortForward.registeredBy) do not appearanywhere in
celilo/— grepped.Version
Changeset says minor. It removes a declared hook from the manifest and raises
the module's floor to celilo 1.0.0, which is more than a bug fix. Not major: the
fleet is already on celilo 1.0.0 with caddy redeployed at 2.3.0, so the provider
side of
on_consumer_removedis live.Gates
test:hooks— 62 pass, 0 failtest:unit— 117 pass, 0 fail, 3 todotypecheck— 0 errorslint— 0 errorsScope is
celilo/plus the manifest and the changeset. The lunacycle applicationitself is untouched.
🤖 Generated with Claude Code